diff options
| author | Asko Nõmm <asko@nth.ee> | 2024-11-11 02:15:09 +0200 |
|---|---|---|
| committer | Asko Nõmm <asko@nth.ee> | 2024-11-11 02:15:09 +0200 |
| commit | 2400d0745dd902f838903d710d805b2a0b6fa132 (patch) | |
| tree | a0aafe667d01a692509e544e016e6f259d0ebd9f | |
| parent | b8dbf4abdc4f7e23e89f28dafa0ffd8f2bdcab70 (diff) | |
Improve testability of FileSystemDriver
| -rw-r--r-- | phpunit.xml | 9 | ||||
| -rw-r--r-- | src/Drivers/FileSystemDriver.php | 5 | ||||
| -rw-r--r-- | tests/FileSystemDriverTest.php | 2 |
3 files changed, 9 insertions, 7 deletions
diff --git a/phpunit.xml b/phpunit.xml index 6ed2107..0d5db01 100644 --- a/phpunit.xml +++ b/phpunit.xml @@ -8,7 +8,14 @@ beStrictAboutCoverageMetadata="false" beStrictAboutOutputDuringTests="false" failOnRisky="false" - failOnWarning="true"> + failOnWarning="true" + testdox="false" + displayDetailsOnIncompleteTests="true" + displayDetailsOnSkippedTests="true" + displayDetailsOnTestsThatTriggerDeprecations="true" + displayDetailsOnTestsThatTriggerErrors="true" + displayDetailsOnTestsThatTriggerNotices="true" + displayDetailsOnTestsThatTriggerWarnings="true"> <testsuites> <testsuite name="default"> <directory>tests</directory> diff --git a/src/Drivers/FileSystemDriver.php b/src/Drivers/FileSystemDriver.php index 6a359aa..551b741 100644 --- a/src/Drivers/FileSystemDriver.php +++ b/src/Drivers/FileSystemDriver.php @@ -25,11 +25,6 @@ class FileSystemDriver implements Driver */ public function log(string $serializedMessage): void { - // If there's no parent directory, try creating one - if (!is_dir($this->directory)) { - mkdir($this->directory, 0600, true); - } - $date = new DateTime(); $file_name = "{$date->format('Y-m-d')}.log"; $path = $this->directory . DIRECTORY_SEPARATOR . $file_name; diff --git a/tests/FileSystemDriverTest.php b/tests/FileSystemDriverTest.php index eb9b873..0ca1241 100644 --- a/tests/FileSystemDriverTest.php +++ b/tests/FileSystemDriverTest.php @@ -122,7 +122,7 @@ class FileSystemDriverTest extends MockeryTestCase $loggr->info('test7'); $loggr->debug('test8'); - $lines = array_filter(explode("\r\n", $data), fn($line) => !empty($line)); + $lines = array_filter(explode("\n", $data), fn($line) => !empty($line)); $this->assertCount(8, $lines); $first_line = $lines[0]; |
